snapcrafters / android-studio

A community-maintained package to easily install Android Studio on Linux
https://developer.android.com/studio/index.html
47 stars 16 forks source link

Various Changes in the sync process #118

Closed soumyaDghosh closed 6 months ago

soumyaDghosh commented 6 months ago
  1. Remove the need of a python file to fetch the version, url
  2. Added codename into the version (closes #110 )
merlijn-sebrechts commented 6 months ago

I wonder, android studio has an internal update checker. Is there any way to find out what URL that uses? Maybe we could use the same url instead of these oneliners

soumyaDghosh commented 6 months ago

@merlijn-sebrechts

image

It's showing that the updates are managed by Snap.

merlijn-sebrechts commented 6 months ago

can you update your PR to get the latest update version and name from https://dl.google.com/android/studio/patches/updates.xml?

This is what the app uses when installed without snap, so this will be long-term stable. You just need to parse the XML. should be easy to get it from this tag: <build apiVersion="AI-231.9392.1" number="AI-231.9392.1.2311.11076708" version="Hedgehog | 2023.1.1">

soumyaDghosh commented 6 months ago

can you update your PR to get the latest update version and name from https://dl.google.com/android/studio/patches/updates.xml?

This url doesn't show the actual version number and the url to download. I'd still need to have a separate url to get the actual version number which is currently 2023.1.1.26

merlijn-sebrechts commented 6 months ago

@soumyaDghosh seems like there is still an issue in the process: https://github.com/snapcrafters/android-studio/actions/runs/7193616466/job/19592441198

soumyaDghosh commented 6 months ago

I have been looking into it from yesterday. And what I am thinking is, the url has / in it, which is probably confusing the sed command. I can't found any answer for it other than this.

EDIT: I can confirm this now.

soumyaDghosh commented 6 months ago

Temporarily.. should we shift to yq?

merlijn-sebrechts commented 6 months ago

Sure!

jnsgruk commented 6 months ago

I commented on #120, but sed can be used with any separator to get around this, so you can do:

sed -i 's|foo|bar' or sed -i 's#foo#bar' etc.