search

snapcrafters / android-studio

A community-maintained package to easily install Android Studio on Linux
https://developer.android.com/studio/index.html
47 stars 16 forks source link

Fix upstream download as its now a tar.gz instead of zip #51

Closed om26er closed 5 years ago

om26er commented 5 years ago

So apparently google is now shipping a tar instead of a zip file. Our script previously looked for the zip so the build was failing, this should fix that.

popey commented 5 years ago

Are we missing some stage packages?

Files from the build host were migrated into the snap to satisfy dependencies that would otherwise not be met. This feature will be removed in a future release. If these libraries are needed in the final snap, ensure that the following are either satisfied by a stage-packages entry or through a part:
usr/lib/x86_64-linux-gnu/libX11.so.6
usr/lib/x86_64-linux-gnu/libXau.so.6
usr/lib/x86_64-linux-gnu/libXdmcp.so.6
usr/lib/x86_64-linux-gnu/libXext.so.6
usr/lib/x86_64-linux-gnu/libpng16.so.
om26er commented 5 years ago

Are we missing some stage packages?

Files from the build host were migrated into the snap to satisfy dependencies that would otherwise not be met. This feature will be removed in a future release. If these libraries are needed in the final snap, ensure that the following are either satisfied by a stage-packages entry or through a part:
usr/lib/x86_64-linux-gnu/libX11.so.6
usr/lib/x86_64-linux-gnu/libXau.so.6
usr/lib/x86_64-linux-gnu/libXdmcp.so.6
usr/lib/x86_64-linux-gnu/libXext.so.6
usr/lib/x86_64-linux-gnu/libpng16.so.

yes, that shouldn't break anything, but I we need to add those into stage-packages, will do another PR for that.

om26er commented 5 years ago

@popey Do ensure its working before promoting, I am waiting to test myself as well.

om26er commented 5 years ago

@popey ok, seems to start fine for me. +1 to promote to stable.

PS: The reason I was paranoid that this release may have issue was because on my local builds I was seeing an issue while trying to install the newly built android-studio snap

error: cannot install snap file: snap is unusable due to bad permissions; contact developer

Though installation from store worked just fine. So there is probably something broken with my setup.