snapcrafters / ci

Repository for shared CI tools and actions
https://github.com/snapcrafters/.github/wiki
MIT License
3 stars 7 forks source link

fix: specify snapcraft-project-root instead of snapcraft-yaml-path #20

Closed jnsgruk closed 12 months ago

jnsgruk commented 12 months ago

This fixes our current build issues where we were passing the path of a snapcraft.yaml to snapcore/action-build, and indeed to snapcraft remote-build.

This is an API change, but I don't think we'd actually adopted the new option anywhere yet, so we're clear! :sweat_smile:

The logic here is that if you have a non-standard location for your snapcraft project, the input you provide is the snapcraft-project-root - or put simply the path from the root of the repo where you'd usually run snapcraft pack yourself. From the project root, there are only 4 valid paths to the snapcraft.yaml, which we can compute easily once we have the project root.

Tested each workflow in a separate repo, both with and without specifying the new option, and they all seem to check out.