search

snapcrafters / ffmpeg

Record, convert, and stream audio and video
9 stars 9 forks source link

Update snapcraft.yaml #63

Closed lucyllewy closed 3 years ago

lucyllewy commented 3 years ago

Disable usage of --enable-nonfree until we can determine whether it is ok for us to redistribute with the flag included.

Fixes: #62

merlijn-sebrechts commented 3 years ago

Note: reading ffmpeg's explanation, --enable-nonfree explicitly makes it unredistributable.: https://github.com/FFmpeg/FFmpeg/blob/master/LICENSE.md#incompatible-libraries

There are certain libraries you can combine with FFmpeg whose licenses are not compatible with the GPL and/or the LGPL. If you wish to enable these libraries, even in circumstances that their license may be incompatible, pass --enable-nonfree to configure. This will cause the resulting binary to be unredistributable.

I'm not sure if we need the TODO in this case, as it seems to be explicit that we can't re-enable it.

ghost commented 3 years ago

Maybe we can add a line to the snap page, and explain if people want to rebuilt their own, they can uncomment the nonfree line?

lucyllewy commented 3 years ago

It's a mess. Some third party libraries are explicitly GPL (not LGPL) such as libx264 - by using those we require the whole work to be GPL2-licensed, which means that any libraries we link to also have to be GPL2-compatible. If we could restrict our use to only LGPL code in ffmpeg we'd be able to redistribute when linking to the non-GPL2-compatible libraries, but we would have to forego using the very helpful libx264 and other GPL2-only libraries/codecs.

Caveat: I am not a lawyer.

merlijn-sebrechts commented 3 years ago

@diddledani I'm not sure if the effort is worth it, but we could always create two channels/tracks of the snap: