snapcrafters / mattermost-desktop

A community-maintained package to easily install Mattermost Desktop on Linux
https://snapcraft.io/mattermost-desktop/
MIT License
11 stars 7 forks source link

Call for testing `mattermost-desktop` #109

Closed github-actions[bot] closed 3 months ago

github-actions[bot] commented 3 months ago

A new version (5.9.0) of mattermost-desktop was just pushed to the latest/candidate channel in the snap store. The following revisions are available.

CPU ArchitectureRevision
amd64762
arm64763

Automated testing

If configured, the snap will be installed in a VM, and any test results or screenshots will be posted to this issue as a comment shortly.

How to test it manually

  1. Stop the application if it was already running
  2. Upgrade to this version by running
snap refresh mattermost-desktop --channel latest/candidate
  1. Start the app and test it out.
  2. Finally, add a comment below explaining whether this app is working, and include the output of the following command.
snap version; lscpu | grep Architecture; snap info mattermost-desktop | grep installed

How to release it

Maintainers can promote this to stable by commenting /promote <rev>[,<rev>] latest/stable [done].

For example

  • To promote a single revision, run /promote <rev> latest/stable
  • To promote multiple revisions, run /promote <rev>,<rev> latest/stable
  • To promote a revision and close the issue, run /promote <rev>,<rev> latest/stable done

You can promote all revisions that were just built with:

/promote 762,763 latest/stable done
github-actions[bot] commented 3 months ago

The following screenshots were taken during automated testing:

window

screen

arif-ali commented 3 months ago

Mostly works

The top right of the window with minimise, maximise and close don't work for me

❱❱ snap version; lscpu | grep Architecture; snap info mattermost-desktop | grep installed

snap    2.63+24.04ubuntu0.1
snapd   2.63+24.04ubuntu0.1
series  16
ubuntu  24.04
kernel  6.8.0-39-generic
Architecture:                         x86_64
installed:          5.9.0            (762) 120MB -
jnsgruk commented 3 months ago

Seems this was changed in the upstream for this release.

Changed the window buttons on the Linux client to use the native ones provided by Electron, removed the frame.

Do you get any denials or logs in the journal when using the buttons? Are you able to test the deb and see if that also suffers?

arif-ali commented 3 months ago

Seems this was changed in the upstream for this release.

Changed the window buttons on the Linux client to use the native ones provided by Electron, removed the frame.

Do you get any denials or logs in the journal when using the buttons? Are you able to test the deb and see if that also suffers?

All my logs when I start it up, a couple of denials, and one error

https://paste.ubuntu.com/p/b93pS6gBNY/

jnsgruk commented 3 months ago

Do the buttons work if you run Mattermost outside of confinement (e.g. by running /snap/mattermost-desktop/762/opt/Mattermost/mattermost-desktop in a terminal)?

arif-ali commented 3 months ago

/snap/mattermost-desktop/762/opt/Mattermost/mattermost-desktop

minimise and close work

maximise/restore doesn't work. Another item, when double-clicking the bar usually would restore to a window, and then maximise.

So, better, but still some issues

jnsgruk commented 3 months ago

Hmm, weird. I can't reproduce. @jugmac00 I know you gave this a test - do the window controls work for you?

jnsgruk commented 3 months ago

Another item, when double-clicking the bar usually would restore to a window, and then maximise

I think this is just a change to behaviour by the upstream adopting the native Electron window controls - so not something we can control in the packaging.

jnsgruk commented 3 months ago

Done some more testing on another machine, and in a VM - window controls seem to be working and confirmed with Jurgen they're also working for him. @arif-ali you might try a snap remove mattermost-desktop --purge and reinstall perhaps? Or login/logout and try in a new session?

/promote 762,763 latest/stable done

github-actions[bot] commented 3 months ago

The following revisions were released to the latest/stable channel: 762,763.

arif-ali commented 3 months ago

@arif-ali you might try a snap remove mattermost-desktop --purge and reinstall perhaps? Or login/logout and try in a new session?

Yup, complete purge, and install, and all good, and everything works as expected :)