Closed github-actions[bot] closed 2 months ago
The following screenshots were taken during automated testing:
Mostly works
The top right of the window with minimise, maximise and close don't work for me
❱❱ snap version; lscpu | grep Architecture; snap info mattermost-desktop | grep installed
snap 2.63+24.04ubuntu0.1
snapd 2.63+24.04ubuntu0.1
series 16
ubuntu 24.04
kernel 6.8.0-39-generic
Architecture: x86_64
installed: 5.9.0 (762) 120MB -
Seems this was changed in the upstream for this release.
Changed the window buttons on the Linux client to use the native ones provided by Electron, removed the frame.
Do you get any denials or logs in the journal when using the buttons? Are you able to test the deb and see if that also suffers?
Seems this was changed in the upstream for this release.
Changed the window buttons on the Linux client to use the native ones provided by Electron, removed the frame.
Do you get any denials or logs in the journal when using the buttons? Are you able to test the deb and see if that also suffers?
All my logs when I start it up, a couple of denials, and one error
Do the buttons work if you run Mattermost outside of confinement (e.g. by running /snap/mattermost-desktop/762/opt/Mattermost/mattermost-desktop
in a terminal)?
/snap/mattermost-desktop/762/opt/Mattermost/mattermost-desktop
minimise and close work
maximise/restore doesn't work. Another item, when double-clicking the bar usually would restore to a window, and then maximise.
So, better, but still some issues
Hmm, weird. I can't reproduce. @jugmac00 I know you gave this a test - do the window controls work for you?
Another item, when double-clicking the bar usually would restore to a window, and then maximise
I think this is just a change to behaviour by the upstream adopting the native Electron window controls - so not something we can control in the packaging.
Done some more testing on another machine, and in a VM - window controls seem to be working and confirmed with Jurgen they're also working for him. @arif-ali you might try a snap remove mattermost-desktop --purge
and reinstall perhaps? Or login/logout and try in a new session?
/promote 762,763 latest/stable done
The following revisions were released to the latest/stable
channel: 762,763
.
@arif-ali you might try a
snap remove mattermost-desktop --purge
and reinstall perhaps? Or login/logout and try in a new session?
Yup, complete purge, and install, and all good, and everything works as expected :)
A new version (5.9.0) of
mattermost-desktop
was just pushed to thelatest/candidate
channel in the snap store. The following revisions are available.Automated testing
If configured, the snap will be installed in a VM, and any test results or screenshots will be posted to this issue as a comment shortly.
How to test it manually
How to release it
Maintainers can promote this to stable by commenting
/promote <rev>[,<rev>] latest/stable [done]
.You can promote all revisions that were just built with: