search

snapcrafters / obs-studio

This is a community-supported modified build of OBS Studio.
https://snapcraft.io/obs-studio
118 stars 35 forks source link

Add background removal plugin #144

Closed mhcerri closed 2 years ago

mhcerri commented 2 years ago

This pull request adds the obs-backgroundremoval plugin and also libonnxruntime, which is used as its dependency.

I've been using this plugin lately and it has worked very well. I created the new snapcraft parts using the instructions provided by the author in the git repo.

mhcerri commented 2 years ago

hi, @diddledani. So it seems the CMakeLists.txt file uses ../ to refer to the source code so it basically assumes the build directory will be right inside the source directory. That makes it harder to use cmake-parameters. I updated the pull request to use the dump plugin for onnxruntime, but I'm keeping the override-build: for obs-backgroundremoval. Please let me know what you think.

mhcerri commented 2 years ago

Hi, sorry for the delay. I updated the commit with the suggested changes and rebased it to the latest master. Let me know what you think.

mhcerri commented 2 years ago

@diddledani @flexiondotorg anything pending on that? I think all the changes are already addressed, correct? Please let me know if I need to change something else. Thanks!