search

snapcrafters / ruff

A community-maintained package to easily install ruff on Linux.
https://astral.sh/ruff
MIT License
1 stars 1 forks source link

Call for testing `ruff` #64

Closed github-actions[bot] closed 3 days ago

github-actions[bot] commented 3 days ago

A new version (0.7.0) of ruff was just pushed to the latest/candidate channel in the snap store. The following revisions are available.

CPU ArchitectureRevision
amd641166
arm641164
armhf1167
ppc64el1165
s390x1163

Automated testing

If configured, the snap will be installed in a VM, and any test results or screenshots will be posted to this issue as a comment shortly.

How to test it manually

  1. Stop the application if it was already running
  2. Upgrade to this version by running
snap refresh ruff --channel latest/candidate
  1. Start the app and test it out.
  2. Finally, add a comment below explaining whether this app is working, and include the output of the following command.
snap version; lscpu | grep Architecture; snap info ruff | grep installed

How to release it

Maintainers can promote this to stable by commenting /promote <rev>[,<rev>] latest/stable [done].

For example

  • To promote a single revision, run /promote <rev> latest/stable
  • To promote multiple revisions, run /promote <rev>,<rev> latest/stable
  • To promote a revision and close the issue, run /promote <rev>,<rev> latest/stable done

You can promote all revisions that were just built with:

/promote 1166,1164,1167,1165,1163 latest/stable done
github-actions[bot] commented 3 days ago

Automated testing success.

Full logs are available at https://github.com/snapcrafters/ruff/actions/runs/11508990324. The first 100, and last 100 lines of the log are displayed in the Summary below.

Logs ``` ruff 0.7.0 (5e6de4e0c 2024-10-17) ::endgroup:: ::group::Help Ruff: An extremely fast Python linter and code formatter. Usage: ruff [OPTIONS] Commands: check Run Ruff on the given files or directories (default) rule Explain a rule (or all rules) config List or describe the available configuration options linter List all supported upstream linters clean Clear any caches in the current directory and any subdirectories format Run the Ruff formatter on the given files or directories server Run the language server analyze Run analysis over Python source code version Display Ruff's version help Print this message or the help of the given subcommand(s) Options: -h, --help Print help -V, --version Print version Log levels: -v, --verbose Enable verbose logging -q, --quiet Print diagnostics, but nothing else -s, --silent Disable all logging (but still exit with status code "1" upon detecting diagnostics) Global options: --config Either a path to a TOML configuration file (`pyproject.toml` or `ruff.toml`), or a TOML ` = ` pair (such as you might find in a `ruff.toml` configuration file) overriding a specific configuration option. Overrides of individual settings using this option always take precedence over all configuration files, including configuration files that were also specified using `--config` --isolated Ignore all configuration files For help with a specific command, see: `ruff help `. ::endgroup:: ::group::Rules: # airflow-variable-name-task-id-mismatch (AIR001) Derived from the **Airflow** linter. ## What it does Checks that the task variable name matches the `task_id` value for Airflow Operators. ## Why is this bad? When initializing an Airflow Operator, for consistency, the variable name should match the `task_id` value. This makes it easier to follow the flow of the DAG. ## Example ```python from airflow.operators import PythonOperator incorrect_name = PythonOperator(task_id="my_task") ``` Use instead: ```python from airflow.operators import PythonOperator my_task = PythonOperator(task_id="my_task") ``` # commented-out-code (ERA001) Derived from the **eradicate** linter. ## What it does Checks for commented-out Python code. ## Why is this bad? Commented-out code is dead code, and is often included inadvertently. It should be removed. ## Known problems Prone to false positives when checking comments that resemble Python code, but are not actually Python code ([#4845]). ## Example ```python # print("Hello, world!") ``` ## Options - `lint.task-tags` [#4845]: https://github.com/astral-sh/ruff/issues/4845 # fast-api-redundant-response-model (FAST001) Derived from the **FastAPI** linter. (Logs truncated. See full logs at: https://github.com/snapcrafters/ruff/actions/runs/11508990324) | ^^^^^^^^ F841 334 | 335 | if fn_info.is_generator: | = help: Remove assignment to unused variable `ret_type` mypyc/irbuild/function.py:420:14: F841 Local variable `func_reg` is assigned to but never used | 418 | class_ir = builder.mapper.type_to_ir[cdef.info] 419 | sig = builder.mapper.fdef_to_sig(fdef, builder.options.strict_dunders_typing) 420 | func_ir, func_reg = gen_func_item(builder, fdef, name, sig, cdef) | ^^^^^^^^ F841 421 | builder.functions.append(func_ir) | = help: Remove assignment to unused variable `func_reg` mypyc/irbuild/function.py:957:29: F841 Local variable `fn_info` is assigned to but never used | 955 | ret_val = builder.builder.call(callable_class_decl, args, arg_kinds, arg_names, line) 956 | builder.add(Return(ret_val)) 957 | arg_regs, _, blocks, _, fn_info = builder.leave() | ^^^^^^^ F841 958 | return FuncIR(decl, arg_regs, blocks) | = help: Remove assignment to unused variable `fn_info` mypyc/irbuild/function.py:1069:22: F841 Local variable `ret_type` is assigned to but never used | 1067 | else: 1068 | builder.add(Unreachable()) 1069 | args, _, blocks, ret_type, fn_info = builder.leave() | ^^^^^^^^ F841 1070 | return FuncIR(func_decl, args, blocks) | = help: Remove assignment to unused variable `ret_type` mypyc/irbuild/function.py:1069:32: F841 Local variable `fn_info` is assigned to but never used | 1067 | else: 1068 | builder.add(Unreachable()) 1069 | args, _, blocks, ret_type, fn_info = builder.leave() | ^^^^^^^ F841 1070 | return FuncIR(func_decl, args, blocks) | = help: Remove assignment to unused variable `fn_info` mypyc/irbuild/function.py:1089:22: F841 Local variable `ret_type` is assigned to but never used | 1087 | builder.add(SetAttr(self_reg, attr_name, value_reg, -1)) 1088 | builder.add(Return(builder.none())) 1089 | args, _, blocks, ret_type, fn_info = builder.leave() | ^^^^^^^^ F841 1090 | return FuncIR(func_decl, args, blocks) | = help: Remove assignment to unused variable `ret_type` mypyc/irbuild/function.py:1089:32: F841 Local variable `fn_info` is assigned to but never used | 1087 | builder.add(SetAttr(self_reg, attr_name, value_reg, -1)) 1088 | builder.add(Return(builder.none())) 1089 | args, _, blocks, ret_type, fn_info = builder.leave() | ^^^^^^^ F841 1090 | return FuncIR(func_decl, args, blocks) | = help: Remove assignment to unused variable `fn_info` mypyc/irbuild/main.py:146:22: F841 Local variable `ret_type` is assigned to but never used | 145 | # Generate special function representing module top level. 146 | args, _, blocks, ret_type, _ = builder.leave() | ^^^^^^^^ F841 147 | sig = FuncSignature([], none_rprimitive) 148 | func_ir = FuncIR( | = help: Remove assignment to unused variable `ret_type` Found 32 errors (2 fixed, 30 remaining). warning: The following rule may cause conflicts when used with the formatter: `ISC001`. To avoid unexpected behavior, we recommend disabling this rule, either by removing it from the `select` or `extend-select` configuration, or adding it to the `ignore` configuration. 10 files reformatted, 302 files left unchanged warning: The following rule may cause conflicts when used with the formatter: `ISC001`. To avoid unexpected behavior, we recommend disabling this rule, either by removing it from the `select` or `extend-select` configuration, or adding it to the `ignore` configuration. 41 files reformatted, 271 files left unchanged ::endgroup:: ::group::Repository: https://github.com/tiangolo/fastapi Cloning into 'ruff-snap-test-qGedY4X5'... All checks passed! docs_src/sql_databases_peewee/sql_app/database.py:7:43: B039 Do not use mutable data structures for `ContextVar` defaults | 5 | DATABASE_NAME = "test.db" 6 | db_state_default = {"closed": None, "conn": None, "ctx": None, "transactions": None} 7 | db_state = ContextVar("db_state", default=db_state_default.copy()) | ^^^^^^^^^^^^^^^^^^^^^^^ B039 | = help: Replace with `None`; initialize with `.set()`` Found 4 errors (3 fixed, 1 remaining). 1283 files left unchanged 189 files reformatted, 1094 files left unchanged ::endgroup:: ```
lengau commented 3 days ago

/promote 1166,1164,1167,1165,1163 latest/stable done

github-actions[bot] commented 3 days ago

The following revisions were released to the latest/stable channel: 1166,1164,1167,1165,1163.