search

snapcrafters / scummvm

A community-maintained package to easily install ScummVM on Linux
MIT License
7 stars 3 forks source link

Update ScummVM logo in the snap package #6

Closed lotharsm closed 4 years ago

lotharsm commented 4 years ago

This PR updates the logo shipped with this snap package to the current official project logo, replacing the old one.

popey commented 4 years ago

Thanks for the PR. I'm confused though, I checked it out, and it's the same as the icon I have installed in Scummvm snap currently?

$ diff -bv snap/gui/scummvm.png  /snap/scummvm/current/meta/gui/scummvm.png
$
lotharsm commented 4 years ago

That's weird indeed. Initially, I snapcrafted from the current master branch of this repository and got the old logo with the white background (also as seen in the snapcrafters store).

After replacing the logo file with the project's current one in this branch, I get the correct logo after snapcrafting it...

So at least for me, the proposed change fixed the application logo.

lotharsm commented 4 years ago

May I give this a little push? :)

During my tests on the last PRs, I noticed that the logo is indeed taken from what's in the file snap/gui/scummvm.png. I get the old application icon without this change in the Ubuntu Dock, the snapcraft.io website and store has the old logo too... I just don't understand right now why your current snap has the new file already?