search

snapcrafters / signal-desktop

Unofficial Signal Desktop installer for Linux
https://snapcraft.io/signal-desktop
GNU Affero General Public License v3.0
34 stars 14 forks source link

feat: add snap config item for tray-icon; disable by default #200

Closed jnsgruk closed 9 months ago

jnsgruk commented 9 months ago

This PR introduces a new snap configuration option tray-icon. When tray-icon is set to true, the signal-desktop binary is launched with the --use-tray-icon flag.

The option is set to false by default.

Fixes https://github.com/snapcrafters/signal-desktop/issues/143 Fixes https://github.com/snapcrafters/signal-desktop/issues/153 Related: https://github.com/snapcrafters/signal-desktop/issues/195

jnsgruk commented 9 months ago

@merlijn-sebrechts can you take a look at this? :)

merlijn-sebrechts commented 9 months ago

On second thought, I think it should be disabled by default since upstream is getting a bunch of weird bug reports from our users complaining about broken systray support. Let's follow upstream on this to keep the peace.

So just address my one request and we can merge this, thanks @jnsgruk !

jnsgruk commented 9 months ago

@merlijn-sebrechts good to go!