[Bug]: Emojis popup is misplaced when the app is in RTL mode

sarmadka commented 9 months ago

What happened?

When you use the snap version of Signal with an RTL language (like Arabic) and click the emojis button next to the text entry field, the emojis popup is viewed behind the side panel, making it unusable.

What should have happened?

The emojis popup should either be shifted to the left, or be viewed on top of the side panel rather than behind it.

Output of `snap info $snap_name`

name:      signal-desktop
summary:   Speak Freely - Private Messenger
publisher: Snapcrafters✪
store-url: https://snapcraft.io/signal-desktop
contact:   https://github.com//snapcrafters/signal-desktop/issues
license:   AGPL-3.0-only
description: |
  **Note: To use the Signal desktop app, you must first install Signal on your phone.**

  Millions of people use Signal every day for free and instantaneous communication anywhere in the
  world. Send and receive high-fidelity messages, participate in HD voice/video calls, and explore a
  growing set of new features that help you stay connected. Signal's advanced privacy-preserving
  technology is always enabled, so you can focus on sharing the moments that matter with the people
  who matter to you.

  - Say anything - State-of-the-art end-to-end encryption (powered by the open source Signal
  Protocol™) keeps your conversations secure. Privacy isn't an optional mode; it's just the way that
  Signal works. Every message, every call, every time.
  - Go fast - Messages are delivered quickly and reliably, even on slow networks. Signal is
  optimized to operate in the most constrained environment possible.
  - Feel free - Signal is a completely independent 501c3 nonprofit. Development is supported by
  users like you. No advertisements. No trackers. No kidding.
  - Be yourself - You can use your existing phone number and address book to securely communicate
  with your friends.
  - Speak up - Whether they live across town or across the ocean, Signal's enhanced audio and video
  quality will make your friends and family feel closer.
  - Whisper in the shadows - Switch to the dark theme if you refuse to see the light.

  **Are you having issues?**

  Let us know by creating a new issue here: https://github.com/snapcrafters/signal-desktop/issues

  **Authors**

  This snap is maintained by the Snapcrafters community, and is not necessarily endorsed or
  officially maintained by the upstream developers.
commands:
  - signal-desktop
snap-id:      r4LxMVp7zWramXsJQAKdamxy6TAWlaDD
tracking:     latest/stable
refresh-date: today at 11:14 PST
channels:
  latest/stable:    6.39.1 2023-11-23 (556) 181MB -
  latest/candidate: 6.39.1 2023-11-23 (556) 181MB -
  latest/beta:      ↑                             
  latest/edge:      ↑                             
installed:          6.39.1            (556) 181MB -

Output of `snap connections $snap_name`

Interface               Plug                                   Slot                            Notes
audio-playback          signal-desktop:audio-playback          :audio-playback                 -
audio-record            signal-desktop:audio-record            :audio-record                   -
browser-support         signal-desktop:browser-support         :browser-support                -
camera                  signal-desktop:camera                  :camera                         -
content[gnome-42-2204]  signal-desktop:gnome-42-2204           gnome-42-2204:gnome-42-2204     -
content[gtk-3-themes]   signal-desktop:gtk-3-themes            gtk-common-themes:gtk-3-themes  -
content[icon-themes]    signal-desktop:icon-themes             gtk-common-themes:icon-themes   -
content[sound-themes]   signal-desktop:sound-themes            gtk-common-themes:sound-themes  -
desktop                 signal-desktop:desktop                 :desktop                        -
desktop-legacy          signal-desktop:desktop-legacy          :desktop-legacy                 -
gsettings               signal-desktop:gsettings               :gsettings                      -
home                    signal-desktop:home                    :home                           -
network                 signal-desktop:network                 :network                        -
opengl                  signal-desktop:opengl                  :opengl                         -
removable-media         signal-desktop:removable-media         -                               -
screen-inhibit-control  signal-desktop:screen-inhibit-control  :screen-inhibit-control         -
unity7                  signal-desktop:unity7                  :unity7                         -
wayland                 signal-desktop:wayland                 :wayland                        -
x11                     signal-desktop:x11                     :x11                            -

Output of `snap version`

snap    2.60.4+23.10.1
snapd   2.60.4+23.10.1
series  16
ubuntu  23.10
kernel  6.5.0-13-generic

Relevant log output

No response

Teminal output of app

No response

merlijn-sebrechts commented 9 months ago

Can you try the upstream package you download from here: https://signal.org/download/

Try it out and see if the issue persists. If it does, it's an issue with the app, and not our snap.

sarmadka commented 9 months ago

I tried the upstream package, and the issue isn't there, as seen in this screen shot:

sarmadka commented 9 months ago

Some more details:

The upstream package was tested on Ubuntu 22.04.
The upstream package is actually a bit newer. It's 6.40.0, compared to the snap version which is still at 6.39.1.

I will give it another attempt on the snap version once it's updated to 6.40.0, and will post my finding here.

sarmadka commented 9 months ago

I confirm that version 6.40.0 fixes the issue for snap signal as well. This bug can be closed.

jnsgruk commented 9 months ago

Excellent, thanks!

snapcrafters / signal-desktop