snapcrafters / sommelier-core

Package a Windows application for Linux using a Snap with Wine.
MIT License
30 stars 10 forks source link

Change theme to 'Light' because 'Modern' has bugs #14

Closed merlijn-sebrechts closed 3 years ago

merlijn-sebrechts commented 3 years ago

The current default theme (ReactOS Modern) is subtly broken: https://github.com/snapcrafters/sommelier-core/issues/10

This switches the theme to the Light theme by Wine developer Zhiyi Zhang, which is a lot more polished.

fixes: https://github.com/snapcrafters/sommelier-core/issues/10

Note to reviewers

This repository contains the source for a part used by a bunch of different snaps. Examples:

You can test it by cloning the repo of one of those snaps and changing the sommelier part to this:

  sommelier:
    plugin: make
    source: https://github.com/galgalesh/sommelier-core.git
    source-branch: wine-light-theme

Rebuild the snap and install it locally. You can see dialog of the first screenshot by running <snap-name>.wine winecfg.

Note: This is the second try for a new theme. The first try had a few regressions.

merlijn-sebrechts commented 3 years ago

@mmtrt the volume slider in foobar2000 is slightly better

image

merlijn-sebrechts commented 3 years ago
mmtrt commented 3 years ago

@galgalesh looks and works good didn't any ground breaking issues apart from this side cut off. test

merlijn-sebrechts commented 3 years ago

Great, thanks @diddledan !