Some applications are failing to open files from file manager.

snapcrafters / sommelier-core

Package a Windows application for Linux using a Snap with Wine.

MIT License

30 stars 10 forks source link

Some applications are failing to open files from file manager. #20

Closed mmtrt closed 2 years ago

mmtrt commented 2 years ago

So some of my sommelier-core ported snaps are failing to open files previously worked just fine.

Failing snaps acrordrdc foobar2000 see user issue though desktop actions do work which do args like /play. irfranview notepad3

Working snaps notepad-plus-plus resourcehacker

I think this need unix path conversion for file arguments.

See my old f2k changes

merlijn-sebrechts commented 2 years ago

I was hoping we didn't need this since the old code assumes every argument which isn't a flag is a path. Plus, it requires users to use unix-style flags instead of windows-style flags. Are there no better options?

I think we could probably solve the file manager issue by including "Z:" in the .desktop file. Something like this: myapp "Z:"$@. That wouldn't fix CLI invocations, however.
This comments claims it's fixed but this requires to use start.exe? Or does it just cause Wine to generate correct .desktop files?

How do apps like PlayOnLinux fix stuff like this? Or is it also broken if you install the app with PlayOnLinux?

mmtrt commented 2 years ago

I've fixed issue without needing to use start /unix in MR so I'm checking if action arg is a valid file then proceed adding z: to it.

Though not tested apps that use flag like args having -add -play but they should work since I'm checking if arg is file else it will proceeds as usuall.