FIX: installing winetricks verbs early

snapcrafters / sommelier-core

Package a Windows application for Linux using a Snap with Wine.

MIT License

30 stars 10 forks source link

Closed mmtrt closed 2 years ago

mmtrt commented 2 years ago

Run the pre-install hook after winetricks since some installers required verbs in wineprefix to work properly.

This also fixes TRICKS envar to work properly otherwise had to add verbs manually to pre-install script to fix installer requirements.

merlijn-sebrechts commented 2 years ago

I think this PR is completely backwards-compatible. I took a quick look on the public repo's using sommelier-core and I don't see any conflicts.

Can you create a PR for this fix to the 1.0 branch too?

merlijn-sebrechts commented 2 years ago

Note: this is now released to 1.0. Apologies for the delay.