search

snapcrafters / sommelier-core

Package a Windows application for Linux using a Snap with Wine.
MIT License
30 stars 10 forks source link

ADD: wine-mono url & download #23

Open mmtrt opened 2 years ago

mmtrt commented 2 years ago

This adds wine mono url checks and downloads it to wine cache to be installed which is required by some .net frameworks.

lucyllewy commented 2 years ago

I don't think this is needed. WINE should automatically fetch this when required.

mmtrt commented 2 years ago

I think this approach is better but could be even better with what I suggested in changes comment.

Shipping mono in platform snaps as snaps are already big enough users complain.

mmtrt commented 2 years ago

I think we need to check for winedlloverrides having mscoree otherwise would be useless to download it if have override set by consumer snap.

merlijn-sebrechts commented 2 years ago

I think we need to check for winedlloverrides having mscoree otherwise would be useless to download it if have override set by consumer snap.

It would be useful to throw a warning when the dll override and SOMMELIER_INSTALL_MONO are both set, but I don't think it's critical. We should definitely add an explanation about this to the docs, though.