search

snapcrafters / sommelier-core

Package a Windows application for Linux using a Snap with Wine.
MIT License
30 stars 10 forks source link

Add ability to install MSI file #26

Closed n8marti closed 2 years ago

n8marti commented 2 years ago

Determine file extension for LOCAL_INSTALL_EXE. Install with msiexec if an MSI file, install with wine if EXE file. Exit with error if neither.

Fixes #25

n8marti commented 2 years ago

Ping. I made the requested changes, but maybe I missed some GitHub step to properly notify you guys?

brlin-tw commented 2 years ago

It somewhat bothers me that the LOCAL_INSTALL_EXE variable may not be an EXEcutable, maybe LOCAL_INSTALLER would be a better name? My 2 cents.

Update: Just passing by, please ignore the recommendation unless the maintainer feels it's necessary.

merlijn-sebrechts commented 2 years ago

@brlin-tw

Thanks for the comment, the variable name can indeed be improved! For backwards compatibility's sake, however, I don't think we should change it. Otherwise, we might become incompatible with some hooks in existing snaps.