search

snapcrafters / sommelier-core

Package a Windows application for Linux using a Snap with Wine.
MIT License
30 stars 10 forks source link

makefile: check `SOMMELIER_NO_THEME` when adding wine theme to consumer snap #45

Closed mmtrt closed 8 months ago

mmtrt commented 8 months ago

Currently sommelier adds WINE light theme to all consumer snaps and with new changes that were backported in https://github.com/snapcrafters/sommelier-core/pull/43 theme is slightly larger that also increases snap size.

So when consumer snap have this defined.

snapcraft.yaml

environment:
  SOMMELIER_NO_THEME: "1"   # WINE theme files are not added to consumer snap otherwise these are added.

Previously with that env sommelier just didn't apply theme but theme files were still present in consumer snaps.

With WINE 9.x and above this theme is not required be reapplied b/c it is currently the default theme already.

jnsgruk commented 8 months ago

This looks fine to me, but I don't know enough about sommelier to make a call. Can you add some context to the PR description to show how this would be used and what it solves? Thanks! :)

mmtrt commented 8 months ago

description updated.