Allow query-string parameters in INSTALL_URL and parse it in `install_app`

snapcrafters / sommelier-core

Package a Windows application for Linux using a Snap with Wine.

MIT License

30 stars 10 forks source link

Allow query-string parameters in INSTALL_URL and parse it in `install_app` #9

Closed lucyllewy closed 3 years ago

lucyllewy commented 3 years ago

Strip everything after a ? in the INSTALL_URL when computing the INSTALL_EXE to allow for URLs that include query-string parameters.
Move the parsing of INSTALL_URL in order to extract INSTALL_EXE into the install_app function - it isn't used anywhere else, and this allows the pre-install hook to change INSTALL_URL before it is parsed into INSTALL_EXE.

merlijn-sebrechts commented 3 years ago

Just as a sanity check, do you foresee any backwards-compatible issues? I'll test these changes on my own snaps and, unless you see an issue, push it to the 1.0 branch.