search

snapcrafters / sublime-merge

A community-maintained package to easily install Sublime Merge on Linux
MIT License
6 stars 8 forks source link

Added workflow #17

Closed soumyaDghosh closed 9 months ago

soumyaDghosh commented 9 months ago

Also adds support for dev releases. Adds -dev after the version if it's a dev version. Also, doesn't creates a call-for-testing issue for dev versions and releases dev versions to edge channel instead of candidate.

soumyaDghosh commented 9 months ago

Branch renaming is needed. I was also thinking to move to core22, but regarding classic snaps, I am currently unsure, if they'll work everywhere

popey commented 9 months ago

Please do not move to core22. You will break the application.

soumyaDghosh commented 9 months ago

No I didn't it's still on core18

popey commented 9 months ago

I know, you said you're thinking of it. I'm saying "don't". Also, please do not merge this until the snap is tested on Ubuntu 20.04 and 22.04, not just 23.10. We have already had the sublime-text snap break, and we should be cautious about changing the entire build process.

I'm also uneasy that you've changed the build process in among a process to add workflow. They are separate things, and should be separate PRs.

soumyaDghosh commented 9 months ago

I'm also uneasy that you've changed the build process in among a process to add workflow. They are separate things, and should be separate PRs.

I made the source of this snap the same as sublime-text

https://github.com/snapcrafters/sublime-text/blob/candidate/snap/snapcraft.yaml#L37

Previously tar file was used, and just changed it to the deb file. And also added a support for the dev builds. There is nothing I changed that is probably dangerous/breaking.

popey commented 9 months ago

They are separate things, and should be separate PRs.

jnsgruk commented 9 months ago

In the spirit of keeping this lean and easy to review; can we also drop the change that introduces dev versions? Let's get this bought up to date with the latest workflows that release to candidate first, then we discuss options for dev versions later?

jnsgruk commented 9 months ago

Ah, one last thing before merging - please remove .github/workflows/test-snap-can-build.yml - we don't need two workflows to build on PRs :)

soumyaDghosh commented 9 months ago

@jnsgruk Just wait a minute before merging, I am testing the source-change. After that merge both together, as this workflow can't work in this current scenario