search

snapcrunch / electron-preferences

A simple, consistent interface for managing user preferences within an Electron application.
MIT License
122 stars 29 forks source link

browserWindowOverrides option has no effect on the created preference window #184

Closed shiyeling closed 1 year ago

shiyeling commented 2 years ago

Describe the bug Trying to change the preference window by setting the browserWindowOverrides option in constructor, but no effect

To Reproduce Steps to reproduce the behavior:

  1. create preference window like this: const preferences = new ElectronPreferences({ ... browserWindowOverrides: { title: 'My title', }, ... });

Expected behavior the preferenec window should have the specified title.

Screenshots image

Machine (please complete the following information):

Additional context Add any other context we should know

pvrobays commented 1 year ago

Hi @shiyeling. Thank you for reporting this bug.

Seems to be an issue due to changes in electron which update the browserWindow title to the HTML header title when loading a page.

I'll create a fix and try to release a patch in the near future.

pvrobays commented 1 year ago

Has been released in 2.8.2. Sorry for the delay