search

snapframework / io-streams-haproxy

HAProxy protocol v1.5 support for io-streams
BSD 3-Clause "New" or "Revised" License
7 stars 17 forks source link

Fix GHC 7.10/network-2.6.2.0 warnings. #9

Closed 23Skidoo closed 9 years ago

gregorycollins commented 9 years ago

I asked if it was safe because I was worried this would happen:

  test/new_ha_proxy: [Failed]
src addr
expected: 127.0.0.1:10000
 but got: 127.0.0.1:4135
  test/new_ha_proxy_6: [Failed]
src addr
expected: [::1]:10000
 but got: [::1]:4135

Last time I checked, the Num constructor byte-order-swapped its argument, and that appears to still be the case. I'll fix this but please at least run the tests? Or do the tests pass on 7.10?

23Skidoo commented 9 years ago

Sorry, I missed that detail! One way to avoid such problems in the future is to use CI (e.g. Travis).

gregorycollins commented 9 years ago

http://buildbot.snapframework.io/

Unfortunately it's only post-commit integration testing, but that's ok -- it'll catch errors that do get committed.