search

snapframework / snap-core

Core type definitions (Snap monad, HTTP types, etc) and utilities for web handlers.
http://snapframework.com/
BSD 3-Clause "New" or "Revised" License
317 stars 85 forks source link

won't compile on 9.2.5 #326

Closed liamzee closed 1 year ago

liamzee commented 1 year ago

Complains about parseTime being missing; and that's only in Data.Time.Compat or whatever it's called these days.

praduca commented 1 year ago

@liamzee are you on windows? I have the same problem, and found a modification on src/Snap/Internal/Http/Types.hs to solve a problem with windows dated from last month

Edit: the modification change the behaviour of compiling the code passing the flag 'portable', but apparently is doing nothing (compiling with or without the flag result in the same error)

Chaddai commented 1 year ago

Having checked, parseTime has been deprecated for quite a long time (recommandation : "use parseTimeM true instead") but definitely disappear in time-1.10 from 2020-03-13.

The cabal bound on time is <1.14 (and was already <1.11 4 years ago) so this should have been a problem for quite some time. Don't know how this got missed. The fix is quite easy though

Chaddai commented 1 year ago

To be more precise, parseTimeM was available since time-1.5 and parseTime was deprecated in the same release. So since 2014. This issue should in fact be closed since this commit fixed it. Let's just wait for the release.

cydparser commented 1 year ago

I've released 1.0.5.1