search

snapframework / snap-server

A fast HTTP server library, which runs Snap web handlers.
http://snapframework.com/
BSD 3-Clause "New" or "Revised" License
196 stars 86 forks source link

Fix exports to work with cabal HEAD #146

Closed hasufell closed 2 years ago

hasufell commented 2 years ago

@Mikolaj

Mikolaj commented 2 years ago

Great job. I'm not sure what severity of warnings we are going to issue in 3.8 for such imperative conditionals as in the original, but certainly it's going to be frowned upon. :)

Mikolaj commented 2 years ago

BTW, the PR just landed: https://github.com/haskell/cabal/pull/7966, so now it would be an excusable warning. After your fix, the warning is, I hope, gone.

mightybyte commented 2 years ago

Let's wait until these changes land in an officially released cabal before we merge this.

hasufell commented 2 years ago

Let's wait until these changes land in an officially released cabal before we merge this.

Why? This works with any cabal version.