search

snapframework / snap-server

A fast HTTP server library, which runs Snap web handlers.
http://snapframework.com/
BSD 3-Clause "New" or "Revised" License
196 stars 86 forks source link

Bump clock dependency a bit #84

Closed k-bx closed 8 years ago

k-bx commented 8 years ago

Also add stack support.

Thank you!

k-bx commented 8 years ago

Will update PR to use submodules soon.

k-bx commented 8 years ago

Sorry, I don't actually see submodules used here. So I can either:

  1. add submodules
  2. remove stack support from here to only let users build it via main "snap" repo?

Please advice.

mightybyte commented 8 years ago

Unfortunately the new versions of clock are broken. See this issue for more info:

https://github.com/corsis/clock/issues/36

I was actually thinking about doing the opposite and making the clock bounds tighter because clock-0.5.2 is also broken as well. I am not inclined to widen the dependency until clock is fixed.

As far as submodules go, we had not set up submodules in this repo yet, although I guess it might not hurt. If we do, we do not need to have heist as a submodule because snap-server does not depend on heist. @gregorycollins is responsible for this package so I'll defer to him on that point.

hvr commented 8 years ago

@mightybyte if you do set up submodules in this repo, it would be a good idea to try to avoid git-submodule cycles between snap and snap-server, as otherwise git clone --recursive https://github.com/snapframework/snap may have undesired behaviour...

mightybyte commented 8 years ago

Closing since we now have constraints that depend on the new fixed version of clock.