Clean up new testsuite - Githubissues

snapframework / snap

Top-level package for the official Snap Framework libraries, includes the snaplets API as well as infrastructure for sessions, auth, and templates.

http://snapframework.com/

BSD 3-Clause "New" or "Revised" License

455 stars 68 forks source link

Clean up new testsuite #114

Closed imalsogreg closed 10 years ago

imalsogreg commented 10 years ago

Combined each Snaplet's testing App into one
Reintroduced Blackbox tests
Moved several files from non-cabal-appdir to the root of the repository (todo - move all test resources into the test directory in a way that works with Snap.Snaplet.Test)
Uncomment the readRequestBody failure test - test suite will fail until we fix bug
Tidied up snap.cabal extra-source-files, tested with cabal sdist and rebuilding from the snap-1.0.0.0.tar.gz to make sure all files are getting packaged up

gregorycollins commented 10 years ago

Thanks for doing all this cleanup work!

gregorycollins commented 10 years ago

Sorry for taking so long to review+merge this, I've been moving between countries.

imalsogreg commented 10 years ago

@gregorycollins No worries about the slow merge. There are a lot of changes to check (and I see that this now has merge conflicts for some reason). Thanks for patience w/ some of my oversights (like -fhpc flag in the library). That's now fixed. Feedback's been great, feel free to keep letting me know if you need more changes before you pull it in.

mightybyte commented 10 years ago

Yeah, this package is currently in a bit of flux because of my changes to heist. Can you try merging master into your branch? If any conflicts come up that you don't understand, let me know and I'll help with them.