The createUser function takes a username as Text, but the loginByUsername function takes a username as a ByteString.
I can understand why the Snaplet would use ByteString to store usernames in an encoding-independent way. However, it might be nice for all functions to take a username input as a ByteString.
Alternatively, forcing Text for usernames throughout might be a good idea.
In regards to the Auth Snaplet
The
createUserfunction takes a username asText, but theloginByUsernamefunction takes a username as aByteString.I can understand why the Snaplet would use
ByteStringto store usernames in an encoding-independent way. However, it might be nice for all functions to take a username input as aByteString.Alternatively, forcing
Textfor usernames throughout might be a good idea.