snapframework / snap

Top-level package for the official Snap Framework libraries, includes the snaplets API as well as infrastructure for sessions, auth, and templates.
http://snapframework.com/
BSD 3-Clause "New" or "Revised" License
455 stars 68 forks source link

MonadLogic explicit instances ghc7.7 #94

Closed schell closed 4 years ago

schell commented 10 years ago

On ghc7.7 I'm getting these errors with cabal build:

src/Control/Access/RoleBased/Internal/Types.hs:28:66:
    Can't make a derived instance of ‛MonadLogic RoleMonad’
      (even with cunning newtype deriving):
      it is not type-safe to use GeneralizedNewtypeDeriving on this class;
      ‛msplit’, at type ‛forall a.
                         m a -> m (Maybe (a, m a))’, cannot be converted safely
    In the newtype declaration for ‛RoleMonad’

src/Control/Access/RoleBased/Internal/Types.hs:33:66:
    Can't make a derived instance of ‛MonadLogic RuleChecker’
      (even with cunning newtype deriving):
      it is not type-safe to use GeneralizedNewtypeDeriving on this class;
      ‛msplit’, at type ‛forall a.
                         m a -> m (Maybe (a, m a))’, cannot be converted safely
    In the newtype declaration for ‛RuleChecker’

I'm up to the task of explicitly defining these, but maybe a little guidance would help? I'm a little out of my element as this is above my skill level I'm afraid.

mightybyte commented 10 years ago

That access control code is currently unused. Let's stop it from being compiled but leave it in the repository.

schell commented 10 years ago

Does that mean it should be removed, commented out or changed in any way?

mightybyte commented 10 years ago

Let's just comment them out in the other-modules section of the .cabal file.

schell commented 10 years ago

Will do. :+1:

imalsogreg commented 4 years ago

Let's close this out. Relevant modules are long gone. Hi Schell :)

schell commented 4 years ago

Hey y'all! Long time no see! This ticket predated us all working together 3 years, funny! Miss ya!