snapjay / ngCart

Really simple shopping cart for AngularJS
http://ngcart.snapjay.com
380 stars 236 forks source link

ngCart.empty() docs not correct #29

Closed tobilg closed 8 years ago

tobilg commented 9 years ago

I had a look in the source code of the ngCart.empty() method at https://github.com/snapjay/ngCart/blob/master/src/ngCart.js#L149 and it seems that the docs at http://ngcart.snapjay.com/docs are not correct:

empty(int) bool: True if all items are removed from cart

I think it would be nice to change this to

empty() : Empty cart (delete all items)

I could think of an ngCart.isEmpty() method which could have the original signature.

warm200 commented 8 years ago

nice catch, and do you know how to fun this function after click checkout button?

interludic commented 8 years ago

Did you ever figure this one out?

tobilg commented 8 years ago

Closing due to inactivity