snapjay / ngCart

Really simple shopping cart for AngularJS
http://ngcart.snapjay.com
380 stars 236 forks source link

Adds ability to send additional payment related data #33

Closed amejiarosario closed 8 years ago

amejiarosario commented 9 years ago

Enables the developers to send additional data such as: mailing address, payment details, ... Solves #8

snapjay commented 9 years ago

Thanks for your contibution. What is your reasoning for this feature? It also seems to be breaking the unit tests

amejiarosario commented 9 years ago

I just took a look at the travis error... It's failing on npm install, it didn't even run the tests... I actually ran the tests locally before the PR an they were all passing.

About the purpose of this change is to be able to use multiple HTTP payment options. E.g. we want to integrate PayPal and Stripe API. With this additional options parameter we can distinguish between the two.