search

snapperben / gulp-mysql-command-file-processor

This a gulp npm module that allows DDL sql files to be run into a MySql server as part of a controlled release
8 stars 4 forks source link

Make continue on query error optional #11

Closed karailiev closed 8 years ago

karailiev commented 8 years ago

Adding option to allow the developer determine if execution should be stopped or continued on query error. Default is set to true to ensure backward compatibility.

iseus commented 8 years ago

Hi, Good addition, thank you.

Shortly this will needs a parameter object instead of attributes... ;)

snapperben commented 8 years ago

Iseus,

It works ok for your test data does it?

Ben

On Sun, Jul 3, 2016 at 1:33 PM, iseus notifications@github.com wrote:

Hi, Good addition, thank you.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/snapperben/gulp-mysql-command-file-processor/pull/11#issuecomment-230151228, or mute the thread https://github.com/notifications/unsubscribe/AMVu3TeYl4oNsdnexi6XWP_gXsIE7aSPks5qR6wZgaJpZM4JD1lD .

iseus commented 8 years ago

I'll check it tomorrow

iseus commented 8 years ago

It works. Good question if we would like to continue running the next sql statement on error or not, currently this additon just prevents gulp to exit if needed. But for this, it works perfectly.

karailiev commented 8 years ago

@iseus I think it should terminate very loudly. But I saw it was removed intentionally in the past, so I decided to make it optional. Even if we keep it optional, I would suggest to have it FALSE by default.

iseus commented 8 years ago

@karailiev You are right in this, usually an sql script builds on previous statements. If one is failing the rest would usually fail too. So let it as is now I think.

@snapperben you can accept the PR.

snapperben commented 8 years ago

@iseus Cheers .....will accept

@karailiev ...good work

On Mon, Jul 4, 2016 at 2:49 PM, iseus notifications@github.com wrote:

@karailiev https://github.com/karailiev You are right in this, usually an sql script builds on previous statements. If one is failing the rest would usually fail too. So let it as is now I think.

@snapperben https://github.com/snapperben you can accept the PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/snapperben/gulp-mysql-command-file-processor/pull/11#issuecomment-230295052, or mute the thread https://github.com/notifications/unsubscribe/AMVu3VBCyjw0AyrFREo1_olVm2qdGfj9ks5qSQ9rgaJpZM4JD1lD .