Closed iseus closed 8 years ago
I tried to avoid API break, that is why database is the last parameter. Optionally a different function/wrapper would be a better solution which transparently provides the npm/mysql createConnection() interface.
Iseus,
Those code changes are a very nice solution!
If you're confident it works (I can't see any issues) then I'll merge it in.
B
On Sun, Apr 3, 2016 at 12:41 AM, iseus notifications@github.com wrote:
I tried to avoid API break, that is why database is the last parameter. Optionally a different function/wrapper would be a better solution which transparently provides the npm/mysql createConnection() interface.
— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/snapperben/gulp-mysql-command-file-processor/pull/7#issuecomment-204827541
Yes, I tested it. I already use it in my development perfectly.
/* ... */
are handled correctly now. it ignores any;
inside the block, but doesn't handle nested comment blocks: #6