Comment blocks and database parameter

iseus commented 8 years ago

comment blocks /* ... */ are handled correctly now. it ignores any ; inside the block, but doesn't handle nested comment blocks: #6
extra parameter added to select default database to use: #5
added 'use strict';
code is slightly reformatted and cleaned up to be a bit more readable/convenient/etc

iseus commented 8 years ago

I tried to avoid API break, that is why database is the last parameter. Optionally a different function/wrapper would be a better solution which transparently provides the npm/mysql createConnection() interface.

snapperben commented 8 years ago

Iseus,

Those code changes are a very nice solution!

If you're confident it works (I can't see any issues) then I'll merge it in.

B

On Sun, Apr 3, 2016 at 12:41 AM, iseus notifications@github.com wrote:

I tried to avoid API break, that is why database is the last parameter. Optionally a different function/wrapper would be a better solution which transparently provides the npm/mysql createConnection() interface.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/snapperben/gulp-mysql-command-file-processor/pull/7#issuecomment-204827541

iseus commented 8 years ago

Yes, I tested it. I already use it in my development perfectly.

snapperben / gulp-mysql-command-file-processor

Comment blocks and database parameter #7