search

snapshot-labs / boost

A protocol for token distribution
MIT License
13 stars 5 forks source link

Add protocol fee #13

Closed Orland0x closed 1 year ago

Orland0x commented 1 year ago

@Orland0x About the token fee wdyt if we could go with the other approach in which the fee stay in the Boost contract and make it clear we dont support rebase tokens?

yeah we could do that. The collect token fee function would be efficient if lots of the same token gets deposited, however if all the deposits are for different tokens then collection will be pretty expensive (1 erc20 transfer for each token) and will be paid by us rather than the DAO using it

Orland0x commented 1 year ago

@Orland0x About the token fee wdyt if we could go with the other approach in which the fee stay in the Boost contract and make it clear we dont support rebase tokens?

yeah we could do that. The collect token fee function would be efficient if lots of the same token gets deposited, however if all the deposits are for different tokens then collection will be pretty expensive (1 erc20 transfer for each token) and will be paid by us rather than the DAO using it

Maybe this is worthwhile. In the worst case it will be like we are subsiding the protocol which is probably a good thing in the beginning. Can always update if it gets too expensive later on