Closed wa0x6e closed 1 year ago
Patch coverage has no change and project coverage change: -0.53%
:warning:
Comparison is base (
6e0e0b1
) 27.25% compared to head (20afeea
) 26.73%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🧿 Current issues / What's wrong ?
Some provider metrics are not labeled by type (json/image).
💊 Fixes / Solution
type
label to remaining providers metrics without it🚧 Changes
type
label to all remaining providers metrics without itprovidersInstrumentation
middleware declaration inside metrics.ts. Inside of using of declaring the middleware usage next to each router, we move it inside the metrics.ts file, and use a kind of hook system to attach it to the correct route. This will reduce the metrics code footprint, instrumentation code should the most unobtrusive possible.🛠️ Tests
http://localhost:3000/metrics
providers_return_count
metric should have a newtype
label value, with value eitherimage
ofjson