snapshot-labs / pineapple

https://pineapple.fyi
MIT License
18 stars 10 forks source link

fix: fix finally block not executed #170

Closed wa0x6e closed 1 year ago

wa0x6e commented 1 year ago

Fix

Fix the finally not being executed due to error thrown inside catch block. Fixed by returning a Promise.reject instead

Chores

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.37% :warning:

Comparison is base (f645d2c) 26.73% compared to head (87fb035) 26.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #170 +/- ## ========================================== - Coverage 26.73% 26.36% -0.37% ========================================== Files 14 14 Lines 576 584 +8 Branches 30 30 ========================================== Hits 154 154 - Misses 414 422 +8 Partials 8 8 ``` | [Files Changed](https://app.codecov.io/gh/snapshot-labs/pineapple/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=snapshot-labs) | Coverage Δ | | |---|---|---| | [src/metrics.ts](https://app.codecov.io/gh/snapshot-labs/pineapple/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=snapshot-labs#diff-c3JjL21ldHJpY3MudHM=) | `0.00% <0.00%> (ø)` | | | [src/providers/index.ts](https://app.codecov.io/gh/snapshot-labs/pineapple/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=snapshot-labs#diff-c3JjL3Byb3ZpZGVycy9pbmRleC50cw==) | `0.00% <0.00%> (ø)` | | | [src/proxy.ts](https://app.codecov.io/gh/snapshot-labs/pineapple/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=snapshot-labs#diff-c3JjL3Byb3h5LnRz) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.