fix: handle CSV votes proposals with shutter - Githubissues

snapshot-labs / snapshot-sidekick

https://sh5.co

MIT License

19 stars 16 forks source link

fix: handle CSV votes proposals with shutter #258

Closed wa0x6e closed 7 months ago

wa0x6e commented 7 months ago

🧿 Current issues / What's wrong ?

Closes #256

Current votes report looks at the type of the returned choices object (number, number[], or {}), to decide how to format them on the CSV file.

This fail on proposals with shutter, which return a string when not closed yet, and still a string when the choice is invalid (edge case)

💊 Fixes / Solution

Stop inferring the choices format from the choices object, and look at the proposal type instead (single, approval, weighted, etc ...)
Do not return any choices for active shutter proposals
Return empty choices for invalid shutter choices

🛠️ Tests

Run yarn test
Test should pass (ignore the failing test due to NFT claimer, see https://github.com/snapshot-labs/snapshot-sidekick/pull/259)
curl -X POST localhost:3005/api/votes/0x0da0673d17298e8f52c88385959952d21c2d0ae2fff2f0fea9df02ca0590cb6a
The CSV file should contain all the votes, with the one with invalid choice shown as no choices