snapshot-labs / snapshot

V1 interface for Snapshot. Join us on Discord http://discord.snapshot.org
https://snapshot.org
MIT License
9.22k stars 1.24k forks source link

Display voting and proposal validation settings on Space About page #3761

Open samuveth opened 1 year ago

samuveth commented 1 year ago

We need to enhance the visibility of proposal and voting validation settings by displaying them on the Space About page. There are two primary validation types, Basic and Gitcoin Gated, each with different information to display.

Required Information

Basic Validation:

Gitcoin Gated Validation:

Before implementing the feature, let's first agree on a basic design that effectively showcases the required information for both validation types. Once we have reached a consensus on the design, we can work on the implementation.

Todmy commented 1 year ago

Let's start with this draft

Image Image

samuveth commented 1 year ago

For Basic validation we should not show minScore on each strategy. The minscore is for all strategies combined. Also would be better to have one element like you did with Gitcoin Gated, where we list the strategies by name.

Like this:

Basic Minimum score: 1 Strategies: erc20, erc712, ...

Todmy commented 1 year ago

Image

samuveth commented 1 year ago

We have proposal and vote validation. Are we going to have a separate block for each?

https://score.snapshot.org/api/validations

Also for proposal validation we have an extra validation arbitrum you can see in the link above it has a proposalValidationOnly property.

samuveth commented 1 year ago

From the example for arbitrum I think we should show all these:


{
"minBps": 1,
"address": "0x912CE59144191C1204E64559FE8253a0e49E6548",
"decimals": 18,
"excludeaddr": "0x00000000000000000000000000000000000A4B86",
"strategies": []
}
Todmy commented 1 year ago

Image Image

zzuziak commented 1 year ago

FYI: More Validation strategies are coming. I guess it's difficult, but maybe we can think of a solution that will be flexible and possible to use for various implementations?