search

snapshot-labs / sx-evm

Core smart contracts of Snapshot X for EVM
https://docs.snapshotx.xyz
20 stars 10 forks source link

Prevent updating if proposal is too close to voting period start #202

Closed pscott closed 1 year ago

pscott commented 1 year ago

Modify updateProposal to make it revert if the block timestamp is too close to the beginning of the vote.

too close is defined as 15 minutes (can be chagned before we merge). It is currently a constant but we could decide to make it a setting and add some setter for it.

Closes #186

codecov[bot] commented 1 year ago

Codecov Report

Merging #202 (9404d2a) into main (9ce547c) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   83.37%   83.37%           
=======================================
  Files          29       29           
  Lines         451      451           
  Branches      113      113           
=======================================
  Hits          376      376           
  Misses         57       57           
  Partials       18       18
Impacted Files Coverage Δ
src/Space.sol 95.38% <100.00%> (ø)
pscott commented 1 year ago

https://github.com/snapshot-labs/sx-evm/issues/186#issuecomment-1591123951