snapshot-labs / sx-evm

Core smart contracts of Snapshot X for EVM
https://docs.snapshotx.xyz
20 stars 10 forks source link

audit: do not count against votes in quorum #203

Closed pscott closed 1 year ago

pscott commented 1 year ago

Closes #175

codecov[bot] commented 1 year ago

Codecov Report

Merging #203 (2064c3f) into main (b7ff1ef) will decrease coverage by 0.43%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   82.05%   81.62%   -0.43%     
==========================================
  Files          29       29              
  Lines         468      468              
  Branches      114      114              
==========================================
- Hits          384      382       -2     
- Misses         70       73       +3     
+ Partials       14       13       -1     
Impacted Files Coverage Δ
...on-strategies/EmergencyQuorumExecutionStrategy.sol 76.47% <100.00%> (-5.89%) :arrow_down:
...ution-strategies/SimpleQuorumExecutionStrategy.sol 77.27% <100.00%> (ø)
Orland0x commented 1 year ago

shall we do the same for EmergencyQuorum?

pscott commented 1 year ago

80547ae7391f143bcb958c9672116a8ed41d000f