search

snapshot-labs / sx-evm

Core smart contracts of Snapshot X for EVM
https://docs.snapshotx.xyz
22 stars 12 forks source link

audit: use uint256 instead of bool in mappings #208

Closed pscott closed 1 year ago

pscott commented 1 year ago

Closes #182

codecov[bot] commented 1 year ago

Codecov Report

Merging #208 (038aeda) into main (5c51bbe) will not change coverage. The diff coverage is 84.61%.

@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files          28       28           
  Lines         459      459           
  Branches      111      111           
=======================================
  Hits          371      371           
  Misses         73       73           
  Partials       15       15
Impacted Files Coverage Δ
src/utils/SignatureVerifier.sol 93.33% <75.00%> (ø)
src/utils/SpaceManager.sol 77.77% <80.00%> (ø)
src/Space.sol 96.21% <100.00%> (ø)
Orland0x commented 1 year ago

looks good, theres also the salts mapping in SignatureVerifier

pscott commented 1 year ago

looks good, theres also the salts mapping in SignatureVerifier

Yeah found 1-2 additional occurrences that I fixed. Cheers for reminding me to check the whole codebase :)