search

snapshot-labs / sx-evm

Core smart contracts of Snapshot X for EVM
https://docs.snapshotx.xyz
20 stars 10 forks source link

audit: Potential Reentrancy in executeQueuedProposal Method #215

Closed Orland0x closed 1 year ago

Orland0x commented 1 year ago

closes #185

codecov[bot] commented 1 year ago

Codecov Report

Merging #215 (727d215) into main (39fb3a0) will decrease coverage by 0.52%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   81.11%   80.60%   -0.52%     
==========================================
  Files          28       28              
  Lines         466      464       -2     
  Branches      112      110       -2     
==========================================
- Hits          378      374       -4     
- Misses         73       74       +1     
- Partials       15       16       +1
Impacted Files Coverage Δ
...tegies/CompTimelockCompatibleExecutionStrategy.sol 82.35% <100.00%> (-0.34%) :arrow_down:
...execution-strategies/TimelockExecutionStrategy.sol 80.00% <100.00%> (-0.44%) :arrow_down:

... and 4 files with indirect coverage changes