search

snapshot-labs / sx-evm

Core smart contracts of Snapshot X for EVM
https://docs.snapshotx.xyz
20 stars 10 forks source link

audit: query timelock queued tx mapping #232

Closed Orland0x closed 1 year ago

Orland0x commented 1 year ago

For the Compound Compatible Timelock, We can query the queued tx mapping in the timelock itself to check for duplicate txs rather than writing to a new mapping in the execution strategy. This saves a storage write for each tx.

codecov[bot] commented 1 year ago

Codecov Report

Merging #232 (b04dd67) into main (7437cfb) will decrease coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   80.00%   79.89%   -0.11%     
==========================================
  Files          30       30              
  Lines         560      557       -3     
  Branches      127      127              
==========================================
- Hits          448      445       -3     
  Misses         95       95              
  Partials       17       17
Impacted Files Coverage Δ
...elocks/CompTimelockCompatibleExecutionStrategy.sol 81.25% <100.00%> (-1.11%) :arrow_down: