snapshot-labs / sx-evm

Core smart contracts of Snapshot X for EVM
https://docs.snapshotx.xyz
20 stars 10 forks source link

do not use `-1` in OZVotes and CompVote #240

Open pscott opened 1 year ago

pscott commented 1 year ago

This opens up a double vote attack because we're not using the snapshot block number.

This was originally designed so that users could vote exactly when the voting period starts but we (in a DM conversation with @Orland0x ) decided the risk is not worth (it's easy to shoot yourself in the foot).