snapshot-labs / sx-monorepo

Snapshot monorepo
https://snapshot.box
MIT License
11 stars 10 forks source link

bug(mana): sponsor tx fail on SN Sepolia #304

Closed bonustrack closed 2 weeks ago

bonustrack commented 4 months ago

For some reason tx to propose are reverting on SN Sepolia with the error "Insufficient max fee: max fee: Fee(17795935068219), actual fee: Fee(84223699650256)"

Example: https://sepolia.starkscan.co/tx/0x5ed0825e5985aee2a0fea50efee024417dfe110bef0b8a201186a0d1f2137e9

On this space: https://testnet.snapshotx.xyz/#/sn-sep:0x0664207ee8c8687c58a4a72f07152e1e612d5107df894c60501e75a665915bf4

bonustrack commented 3 months ago

Got this error now on this space: https://testnet.snapshotx.xyz/#/sn-sep:0x0296c8c33760092c8006387c7bd77e1070f9851d49f949bb9c7adff32b4d5982/create/bjaqh

image
Sekhmet commented 3 months ago

Only errors I see are from rate limits:

63: An unexpected error occurred: "HTTP status client error (429 Too Many Requests) for url (https://alpha-sepolia.starknet.io/gateway/add_transaction)

Not sure why we use starknet.io gateway though 🤔

bonustrack commented 3 months ago

@Sekhmet Probably because this is the sequencer (there is only 1 sequencer on Starknet) it's likely to be the only way to broadcast a tx.

Sekhmet commented 3 months ago

Can you try to propose again?

Looks like on our side it works fine as we ourselves do not call sequencer - we call RPC to broadcast a transactions but it looks like Infura is getting rate limited on sequencer.

bonustrack commented 3 months ago

@Sekhmet Works now

Sekhmet commented 3 months ago

I don't think there is anything we can do about it on our side as it looks like to be Infura getting rate-limited by Sequencer.

bonustrack commented 3 months ago

I still see the issue happening, here is on this space: https://testnet.snapshotx.xyz/#/sn-sep:0x019fe8e10c15ced8c06a1052ab9632d6e4cfb0b447525a6779906b081d31f5d3 using whitelist to create a proposal https://sepolia.starkscan.co/tx/0x645abd9ca88de98f246c6afcc31f64080c5dc18ab38fd4eb095f357700674de

Sekhmet commented 3 months ago

Mana wasn't deployed with new change, can you try again?

bonustrack commented 3 months ago

Works now

bonustrack commented 3 months ago

Failed again https://sepolia.starkscan.co/tx/0xfff954a4677a7d00630a4158c38e3697159ea140a33d0e3c759ad81529c527

Sekhmet commented 3 months ago

That is huge difference, it wants over 3 times more for fee (and we already do 1.5x). I guess we could overestimate it by a lot (like 5x) 🤔

bonustrack commented 3 months ago

That's weird that we have to define a max fee this way, doing tx to change settings isn't a problem, I wonder what is the difference with propose with sig

Sekhmet commented 3 months ago

That's weird that we have to define a max fee this way, doing tx to change settings isn't a problem, I wonder what is the difference with propose with sig

Those go through Mana and because we have nonce manager we first estimate the transaction and then invoke it (so we have stable nonce in both transactions). And this can get out of sync.

bonustrack commented 3 months ago

I see, it's weird the estimate is so much off