snapshot-labs / sx-monorepo

Snapshot monorepo
https://snapshot.box
MIT License
11 stars 10 forks source link

feat: add notification page #317

Closed wa0x6e closed 3 months ago

wa0x6e commented 3 months ago

Summary

Closes: #315

Changes

How to test

  1. Log in with an account with some followed spaces
  2. Go to /notifications
  3. You should see start and end activities from your followed spaced
  4. You should see the unread count and link to /notifications in the sidebar
  5. You should see the unread count in the page title
  6. Unread notifications should have a light grey background
  7. Navigate to some other page, from the Nav sidebar (the notifications count should disappear)
  8. Navigate back to /notifications
  9. All notifications should now be marked as read (transparent background)
  10. To test the auto-refresh, edit the REFRESH_INTERVAL in the notifications store to something smallet (like 15s)
  11. Open the dev console, you should see new requests to graphql proposals endpoint on each refresh (2 for each network)
  12. Switch wallet, it should refresh the notifications content

Notifications should be marked as all read only once the /notifications page is visited.

bonustrack commented 3 months ago

Can you use different background color (bg-skin-border with 20% opacity) for unreal events?

image

Can you also show a counter of unred events in the sidebar?

wa0x6e commented 3 months ago

@bonustrack UX/UI ready to be reviewed

wa0x6e commented 3 months ago

UX looks good, but on first load notifications doesn't appear

image

And when I change account I dont see notification unread counter

Can not reproduce the case where notifications doesn't appear on first load. Do you see any console errors, and do you see the request to graphql ?

wa0x6e commented 3 months ago

Notifications now reload on account change

wa0x6e commented 3 months ago

@bonustrack merge conflict resolved

bonustrack commented 3 months ago

Actually I just noticed some issue, the "Voted" indicator is not visible anymore, not sure if loading is broken. And in "Home" I can see the message "There isn't any proposals" before proposals get loaded.

wa0x6e commented 3 months ago

There is no "Voted" indicator in the notifications page

wa0x6e commented 3 months ago

Actually I just noticed some issue, the "Voted" indicator is not visible anymore, not sure if loading is broken. And in "Home" I can see the message "There isn't any proposals" before proposals get loaded.

Will be fixed in #344

bonustrack commented 3 months ago

There is no "Voted" indicator in the notifications page

I mean in "Home" page I can't see the "Voted" indicator

wa0x6e commented 3 months ago

No Notifications message flashing fixed