search

snapshot-labs / sx-monorepo

Snapshot monorepo
https://snapshot.box
MIT License
11 stars 10 forks source link

feat: vote and create/update proposals with session key #320

Closed wa0x6e closed 1 month ago

wa0x6e commented 3 months ago

Summary

Closes: #319

This PR add the ability to use session key for additional actions:

How to test

Need to wait for https://github.com/snapshot-labs/snapshot-sequencer/pull/347 to be merged first, or use local branch

New proposal

  1. Try to create a proposal on an offchain space
  2. It should ask to sign a tx to create a session key if not already created
  3. It should create the proposal without asking to sign additional tx

Update proposal

  1. Go to your space setting on v1, and add some voting delay (to create pending proposals)
  2. Go to sx, and create a new proposal
  3. Edit the new proposal
  4. It should update without tx signing

Vote

  1. Vote on an offchain proposal
  2. It should cast the vote without tx signing

To-Do

Sekhmet commented 1 month ago

What is status of this PR? I see that sequencer PR is not merged, but approved. It has lots of merge conflicts currently as well. If it's still WIP can we turn it into a draft?

wa0x6e commented 1 month ago

Converting to draft. This PR was ready technically at the time, but stalled for security issues on sequencer. Will reopen again when the task will surface again in later cycles

wa0x6e commented 1 month ago

Will open a new one again when needed, as this one is too old and has too much merge conflict