snapshot-labs / sx-monorepo

Snapshot monorepo
https://snapshot.box
MIT License
14 stars 12 forks source link

style: improve editor layout #336

Closed bonustrack closed 4 months ago

bonustrack commented 4 months ago

We should move voting type and choice selection on a right sidebar, with same size as a proposal right sidebar, by default "Single choice" should be selected. On button click it should open a modal with all the choices without image (similar than on Snapshot). image

Sekhmet commented 4 months ago

On button click it should open a modal with all the choices without image (similar than on Snapshot).

I don't think the UI you included is clear about this. This button doesn't suggest you can click on it to change anything, maybe should use chevron down icon instead of checkmark? Now it looks just like there is one option and nothing else.

bonustrack commented 4 months ago

@Sekhmet Yes make sense we can use chevron-down instead for the icon

Sekhmet commented 4 months ago

@bonustrack What about spaces that don't have voting type selector? Should we in that case use default layout without sidebar?

bonustrack commented 4 months ago

@Sekhmet You can keep same layout with the sidebar, we will later add some info about the start and end date of the proposal there.