search

snapshot-labs / sx-monorepo

Snapshot X monorepo
https://snapshot.box
MIT License
11 stars 10 forks source link

refactor(ui): migrate table to div #341

Closed wa0x6e closed 2 months ago

wa0x6e commented 2 months ago

Summary

Closes: #339 #330 #145

Migrate tables to div for pages:

Migrating to div will fix a few issues with table

How to test

  1. Go to a proposal votes page
  2. It should display data as before
  3. The voting power background should display correctly on webkit engine (https://github.com/snapshot-labs/sx-monorepo/issues/145)
  4. Go to the delegates and leaderboard page
  5. It should display data as before
  6. The 1px gap described in https://github.com/snapshot-labs/sx-monorepo/issues/330 should be fixed
Sekhmet commented 2 months ago
image

Can we align headers to rows? Right now headers are a bit more to the right than the values.

Looks like it happens not on all spaces so there it is: http://localhost:8080/#/s:cakevote.eth/proposal/0x41feef37054b6c090a2629d6eb2ed39f426f169b725cb565903e6b3ba1771bcc/votes

wa0x6e commented 2 months ago
image

Can we align headers to rows? Right now headers are a bit more to the right than the values.

Looks like it happens not on all spaces so there it is: http://localhost:8080/#/s:cakevote.eth/proposal/0x41feef37054b6c090a2629d6eb2ed39f426f169b725cb565903e6b3ba1771bcc/votes

Fixed. Also prevented sort arrow icons from shrinking

Sekhmet commented 2 months ago

@wa0x6e looks like you forgot to push changes?

Sekhmet commented 2 months ago

Also, do you know if we can do something about uneven columns when going smaller?

image

Choice column seems to be moving around from row to row.

wa0x6e commented 2 months ago

Yes, it's fixed in the commit, but I can not find it anymore ><"

wa0x6e commented 2 months ago

Should be good now