style: voting power showing too many decimals on votes page

snapshot-labs / sx-monorepo

Snapshot X monorepo

https://snapshot.box

MIT License

11 stars 10 forks source link

style: voting power showing too many decimals on votes page #342

Closed bonustrack closed 1 month ago

bonustrack commented 2 months ago

Voting power on the following page is displayed as 0.000000000000000002 UNI, instead it should be ~0. We should show max 3 decimals, if the amount is lower than 0.001 then we show ~0.

https://testnet.snapshotx.xyz/#/sn-sep:0x019fe8e10c15ced8c06a1052ab9632d6e4cfb0b447525a6779906b081d31f5d3/proposal/5/votes

wa0x6e commented 2 months ago

@bonustrack

Should we use 3 decimals max, or use 2 like in the "My voting power" indicator ?
Should we add a tooltip to display the full value ?

bonustrack commented 2 months ago

When it's less than 0.001 we can show just ~0. If it's 0.12345678 we can show 0.123, we don't need tooltip

bonustrack commented 1 month ago

This is not fixed for me

https://testnet.snapshotx.xyz/#/sn-sep:0x019fe8e10c15ced8c06a1052ab9632d6e4cfb0b447525a6779906b081d31f5d3/proposal/5/votes

Sekhmet commented 1 month ago

It failed to merge due to some conflicts, was later resubmitted: https://github.com/snapshot-labs/sx-monorepo/pull/352