search

snapshot-labs / sx-monorepo

Snapshot X monorepo
https://snapshot.box
MIT License
11 stars 10 forks source link

fix: fix followed space list not returning correct space network #365

Closed wa0x6e closed 1 month ago

wa0x6e commented 1 month ago

Summary

This PR fix an issue where the list of followed spaces loaded from the offchain network API was always returned with networkID s (or sn).

This was the correct behavior until we refactored sequencer to also support onchain spaces.

With this PR, list of spaces from loadFollows will have the correct networkID

How to test

  1. Follow an onchain space
  2. Refresh the page
  3. Before the fix: onchain space does not appear in the sidebar, after the fix, it should appear in the sidebar

TODO

Having the offchain network returning a mix list of onchain and offchain spaces is not optimal, and confusing. This solution is temporary, until we implement https://github.com/snapshot-labs/sx-monorepo/issues/359

Sekhmet commented 1 month ago

I cannot reproduce it on master. I unfollow my space, follow it again, refresh page and space seems to be followed properly, showing up in sidebar.

wa0x6e commented 1 month ago

I cannot reproduce it on master. I unfollow my space, follow it again, refresh page and space seems to be followed properly, showing up in sidebar.

is it an onchain space ?