feat: add support for spaces search - Githubissues

snapshot-labs / sx-monorepo

Snapshot X monorepo

https://docs.snapshotx.xyz

MIT License

11 stars 10 forks source link

feat: add support for spaces search #391

Closed wa0x6e closed 1 month ago

wa0x6e commented 1 month ago

Summary

Closes: #389

This PR add the ability to search for a space

UI/UX changes

The search input should be pre-populated on page load with the query string from the url (q=xxx) if available
Use different placeholder for space and proposal search
Explore page now have a message when no spaces results
Move explore page protocol to query string in the url (?p=snapshot|snapshotx)

New features

Using the topnav searchbar from the "My" pages should redirect to the explore page, and show a list of spaces matching the search results

How to test

Go to http://localhost:8080/#/home
Search for a space using the top searchbar
It should show your results in the /explore page
You can switch protocol, without to search for the keyword again
The URL should reflect your search filters, reloading the page will keep the same results

TODO

[x] Code improvement

wa0x6e commented 1 month ago

PR ready UI/UX/Feature wise, will take another look later for code improvement before asking for code review

bonustrack commented 1 month ago

Space explore page was working initially then it now stuck for me with this error:

wa0x6e commented 1 month ago

Space explore page was working initially then it now stuck for me with this error:

This is because hub is returning null when no results. A pr already open to fix that

wa0x6e commented 1 month ago

Space explore page was working initially then it now stuck for me with this error:

Should now be fixed