bug(style): abstain icon on votes page should be gray

snapshot-labs / sx-monorepo

Snapshot X monorepo

https://docs.snapshotx.xyz

MIT License

11 stars 10 forks source link

bug(style): abstain icon on votes page should be gray #396

Closed bonustrack closed 3 weeks ago

bonustrack commented 3 weeks ago

Currently the abstain icon on the votes page for Highlight votes is not fully gray, the dash is using link color, we should fix that

https://testnet.snapshotx.xyz/#/sep:0x5559e6c038fD0494277ac85ab6576843A6d0187b/proposal/7/votes

wa0x6e commented 3 weeks ago

Also, in this proposal, why is the result empty, even though there are 2 votes ? It leads to division by 0 in the voting power percentage

bonustrack commented 3 weeks ago

These are offchain votes using Highlight, there might be an issue

Sekhmet commented 3 weeks ago

This is fixed by Highlight, we were mapping our votes wrong: https://github.com/snapshot-labs/highlight/pull/19

Sekhmet commented 3 weeks ago

Also, in this proposal, why is the result empty, even though there are 2 votes ? It leads to division by 0 in the voting power percentage

This space is misconfigured (it doesn't have Axiom executor strategy configured, but we forced some votes anyway), Highlight (API that processed Axiom votes) doesn't actually validate if you have VP so we can cast 0 VP votes, because there is no Axiom executor there is no quorum as well, so the math is broken.

Once we validate everything properly on Highlight it shouldn't be the case.